You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The cut_angle parameter and functionality introduced by #138 leads to a deadlock inside a while(true)-loop, for specific values of the cut_angle parameter in relation to the FOV specified in the velodyne's user interface.
I found out about this issue using a VLP16 and commit ef2345e of this repository.
There are several possible configurations for the relation between the two angles (Start, Stop) specifying the FOV of the velodyne in the velodyne's user interface and the cut_angle parameter (c):
The
cut_angle
parameter and functionality introduced by #138 leads to a deadlock inside awhile(true)
-loop, for specific values of thecut_angle
parameter in relation to the FOV specified in the velodyne's user interface.I found out about this issue using a VLP16 and commit ef2345e of this repository.
There are several possible configurations for the relation between the two angles (Start, Stop) specifying the FOV of the velodyne in the velodyne's user interface and the
cut_angle
parameter (c):For the 3rd configuration the
break
in thewhile(true)
(https://github.com/ros-drivers/velodyne/blob/master/velodyne_driver/src/driver/driver.cc#L189) is never reached and the loop will never stop.My solution to this was to replace the lines 180-186 in https://github.com/ros-drivers/velodyne/blob/master/velodyne_driver/src/driver/driver.cc with:
I tested this with the same configurations and it worked.
If you want me to, I can submit a pull request for my fix.
The text was updated successfully, but these errors were encountered: