Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies in package.xml #331

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

clalancette
Copy link
Contributor

Ensure that we depend on ament_cmake_ros as appropriate.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Ensure that we depend on ament_cmake_ros as appropriate.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@JWhitleyWork
Copy link
Contributor

@clalancette - I'm actually not familiar. What's the difference between ament_cmake and ament_cmake_ros?

@clalancette
Copy link
Contributor Author

@clalancette - I'm actually not familiar. What's the difference between ament_cmake and ament_cmake_ros?

Essentially, ament_cmake_ros adds a few defaults to ament_cmake that are more consistent for ROS nodes. Things like building shared libraries by default, etc. In the end, it is not super important whether we use ament_cmake or ament_cmake_ros, but the package.xml and CMakeLists.txt have to agree (otherwise you can get build failures on the buildfarm).

@JWhitleyWork JWhitleyWork merged commit 0dc0e90 into ros-drivers:dashing-devel Feb 18, 2020
@clalancette clalancette deleted the fix-deps branch February 18, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants