Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multiple velodynes (improved) #39

Merged
merged 4 commits into from
Sep 22, 2015
Merged

support for multiple velodynes (improved) #39

merged 4 commits into from
Sep 22, 2015

Conversation

bricerebsamen
Copy link
Contributor

This is an improvement on @ddillenberger implementation of the multi velodyne support. From what I understand from his design, and from what I experienced today on my setup (4 16-beam velodynes), @ddillenberger code allows to read data from one and only one laser at the same time.

With this pull request, we add support for reading data simultaneously from several lidars at the same time. Each lidar must be configured with a separate IP address and to broadcast on a separate port.

With this code, we were able to read from 4 velodyne at the same time.

Credits also go to @ddillenberger and @ahendrix for this pull request.

@bricerebsamen
Copy link
Contributor Author

I forgot to mention: compared to @ddillenberger implementation, we added a parameter for the udp port to read from.

@bricerebsamen bricerebsamen changed the title Multivelodyne support (improved) support for multiple velodyne (improved) Jan 8, 2015
@bricerebsamen bricerebsamen changed the title support for multiple velodyne (improved) support for multiple velodynes (improved) Jan 8, 2015
@bricerebsamen
Copy link
Contributor Author

This has been running with success on our system for quite some time already.

@jack-oquin
Copy link
Member

Good to know, Brice.

Sorry I have been so slow to work on this driver. I am not actively using it myself these days.

Would you be interested in being a co-maintainer?

@bricerebsamen
Copy link
Contributor Author

OK. But I'm not using it much either. I have access to a few Pucks and a 64.
However, I'm using custom code for converting to a point cloud, because I'm using a different calibration file. So I would not be able to do much testing...

@jack-oquin
Copy link
Member

Is your calibration method proprietary, or would you be interested in sharing it?

@bricerebsamen
Copy link
Contributor Author

it's proprietary.

The good news is that for the Pucks, it we don't need a calibration file.

@bricerebsamen
Copy link
Contributor Author

@jack-oquin OK I'll volunteer to be a maintainer

@jack-oquin
Copy link
Member

I appreciate your help.

PierrickKoch added a commit to PierrickKoch/velodyne that referenced this pull request Sep 3, 2015
jack-oquin added a commit that referenced this pull request Sep 22, 2015
support for multiple velodynes
@jack-oquin jack-oquin merged commit 89aa0a6 into ros-drivers:master Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants