Add option timestamp first packet #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Jan 5, 2022
| @@ -71,6 +71,7 @@ class VelodyneDriver final : public rclcpp::Node | |||
| int cut_angle; // cutting angle in 1/100° | |||
| double time_offset; // time in seconds added to each velodyne time stamp | |||
| bool enabled; // polling is enabled | |||
| bool timestamp_first_packet; | |||
There was a problem hiding this comment.
Nit: can you please add a comment to this line, to be consistent with the rest of the structure?
There was a problem hiding this comment.
@clalancette add comment at c78129f
…et instead of last packet Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
wep21
force-pushed
the
add-option-timestamp-first-packet
branch
from
c761847
to
c78129f
Compare
clalancette
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2 porting for #283
a part of #434