Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geodesy: remove deprecated geodesy.gen_uuid module #4

Closed
jack-oquin opened this issue Mar 18, 2013 · 6 comments
Closed

geodesy: remove deprecated geodesy.gen_uuid module #4

jack-oquin opened this issue Mar 18, 2013 · 6 comments
Assignees
Milestone

Comments

@jack-oquin
Copy link
Member

Take it out before release version 1.0.0.

@ghost ghost assigned jack-oquin Mar 18, 2013
@jack-oquin
Copy link
Member Author

I think version 1.0.0 is still a long ways off. This was originally intended for Hydro, but not fixed then.

Since Indigo just came out, we can either:

  • add a deprecation warning now, then remove it in Jade
  • remove it now

I have no idea if anyone is actually using gen_uuid. The unique_identifier packages have been out for several releases now.

@roehling, @mikepurvis: what do you recommend?

@jack-oquin jack-oquin modified the milestones: hydro, indigo Aug 31, 2014
@mikepurvis
Copy link
Member

We have a dependency on gesodesy for UTM conversions, nothing to do with UUID. I'm happy to see either. Would prefer a release with no change than too much more of a wait.

@jack-oquin
Copy link
Member Author

It is already been released with only your C++ language fix.

I would like to make another Indigo release to at least log a deprecation warning if those obsolete functions get called.

@roehling
Copy link
Contributor

roehling commented Sep 3, 2014

We do not use geodesy.gen_uuid either.

I generally dislike sudden and unannounced interface changes. But geodesy.gen_uuid.generate(url,id) is essentially the same as unique_id.fromURL(url+str(id)), geodesy.gen_uuid.makeUniqueID(url,id) is equivalent to unique_id.toMsg(unique_id.fromURL(url+str(id))), and neither is a core function of the package, so I think it's okay to remove it now and be done with it.

@jack-oquin
Copy link
Member Author

Timo, I agree with both of your statements: that sudden removal is generally a bad idea, and that it is OK in this case.

The unique_id alternative has been available since Fuerte, and is quite stable, whereas this package was clearly labelled "experimental".

@jack-oquin
Copy link
Member Author

geographic_info-0.4.0 released with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants