Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing uuid_msgs/UniqueID to unique_identifier_msgs/UUID #26

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added geodesy/COLCON_IGNORE
Empty file.
Empty file added geographic_info/COLCON_IGNORE
Empty file.
29 changes: 18 additions & 11 deletions geographic_msgs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ endif()
find_package(ament_cmake REQUIRED)
find_package(std_msgs REQUIRED)
find_package(geometry_msgs REQUIRED)
find_package(uuid_msgs REQUIRED)
find_package(unique_identifier_msgs REQUIRED)
find_package(rosidl_default_generators REQUIRED)
find_package(builtin_interfaces REQUIRED)

rosidl_generate_interfaces(${PROJECT_NAME}
rosidl_generate_interfaces(${PROJECT_NAME}
"msg/BoundingBox.msg"
"msg/GeographicMapChanges.msg"
"msg/GeographicMap.msg"
"msg/GeographicMapChanges.msg"
"msg/GeographicMap.msg"
"msg/GeoPath.msg"
"msg/GeoPoint.msg"
"msg/GeoPointStamped.msg"
Expand All @@ -32,33 +32,40 @@ rosidl_generate_interfaces(${PROJECT_NAME}
"srv/GetGeoPath.srv"
"srv/GetRoutePlan.srv"
"srv/UpdateGeographicMap.srv"
DEPENDENCIES
DEPENDENCIES
builtin_interfaces
std_msgs
geometry_msgs
uuid_msgs
geometry_msgs
unique_identifier_msgs
)

set(INCLUDE_DIRS ${ament_cmake_INCLUDE_DIRS} ${std_msgs_INCLUDE_DIRS}
${geometry_msgs_INCLUDE_DIRS} ${uuid_msgs_INCLUDE_DIRS}
${geometry_msgs_INCLUDE_DIRS} ${unique_identifier_msgs_INCLUDE_DIRS}
${rosidl_default_generators_INCLUDE_DIRS})
include_directories(${INCLUDE_DIRS})

set(LIBRARY_DIRS ${ament_cmake_LIBRARY_DIRS} ${std_msgs_LIBRARY_DIRS}
${geometry_msgs_LIBRARY_DIRS} ${uuid_msgs_LIBRARY_DIRS}
${geometry_msgs_LIBRARY_DIRS} ${unique_identifier_msgs_LIBRARY_DIRS}
${rosidl_default_generators_LIBRARY_DIRS})

link_directories(${LIBRARY_DIRS})

set(LIBS ${ament_cmake_LIBRARIES} ${std_msgs_LIBRARIES}
${geometry_msgs_LIBRARIES} ${uuid_msgs_LIBRARIES}
${geometry_msgs_LIBRARIES} ${unique_identifier_msgs_LIBRARIES}
${rosidl_default_generators_LIBRARIES})

ament_export_dependencies(ament_cmake)
ament_export_dependencies(std_msgs)
ament_export_dependencies(geometry_msgs)
ament_export_dependencies(uuid_msgs)
ament_export_dependencies(unique_identifier_msgs)
ament_export_dependencies(rosidl_default_generators)
ament_export_dependencies(rosidl_default_runtime)

ament_export_include_directories(${INCLUDE_DIRS})

install(
FILES geographic_msgs_mapping_rule.yaml
DESTINATION share/${PROJECT_NAME}
)

ament_package()
8 changes: 8 additions & 0 deletions geographic_msgs/geographic_msgs_mapping_rule.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This file defines mappings between ROS 1 and ROS 2 interfaces.
# It is used with the ros1_bridge to allow for communcation between ROS 1 and ROS 2.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used with the ros1_bridge to allow for communcation between ROS 1 and ROS 2.

nit sp. communication


-
ros1_package_name: 'uuid_msgs'
ros1_message_name: 'UniqueID'
ros2_package_name: 'unique_identifier_msgs'
ros2_message_name: 'UUID'
2 changes: 1 addition & 1 deletion geographic_msgs/msg/GeographicMap.msg
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
std_msgs/Header header # stamp specifies time
# frame_id (normally /map)

uuid_msgs/UniqueID id # identifier for this map
unique_identifier_msgs/UUID id # identifier for this map
BoundingBox bounds # 2D bounding box containing map

WayPoint[] points # way-points
Expand Down
2 changes: 1 addition & 1 deletion geographic_msgs/msg/GeographicMapChanges.msg
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ std_msgs/Header header # stamp specifies time of change
# frame_id (normally /map)

GeographicMap diffs # new and changed points and features
uuid_msgs/UniqueID[] deletes # deleted map components
unique_identifier_msgs/UUID[] deletes # deleted map components
4 changes: 2 additions & 2 deletions geographic_msgs/msg/MapFeature.msg
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
#
# Feature lists may also contain other feature lists as members.

uuid_msgs/UniqueID id # Unique feature identifier
uuid_msgs/UniqueID[] components # Sequence of feature components
unique_identifier_msgs/UUID id # Unique feature identifier
unique_identifier_msgs/UUID[] components # Sequence of feature components
KeyValue[] props # Key/value properties for this feature
2 changes: 1 addition & 1 deletion geographic_msgs/msg/RouteNetwork.msg
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

std_msgs/Header header

uuid_msgs/UniqueID id # This route network identifier
unique_identifier_msgs/UUID id # This route network identifier
BoundingBox bounds # 2D bounding box for network

WayPoint[] points # Way points in this network
Expand Down
4 changes: 2 additions & 2 deletions geographic_msgs/msg/RoutePath.msg
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@

std_msgs/Header header

uuid_msgs/UniqueID network # Route network containing this path
uuid_msgs/UniqueID[] segments # Sequence of RouteSegment IDs
unique_identifier_msgs/UUID network # Route network containing this path
unique_identifier_msgs/UUID[] segments # Sequence of RouteSegment IDs
KeyValue[] props # Key/value properties
6 changes: 3 additions & 3 deletions geographic_msgs/msg/RouteSegment.msg
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
# known path from one way point to another. If the path is two-way,
# there will be another RouteSegment with "start" and "end" reversed.

uuid_msgs/UniqueID id # Unique identifier for this segment
unique_identifier_msgs/UUID id # Unique identifier for this segment

uuid_msgs/UniqueID start # beginning way point of segment
uuid_msgs/UniqueID end # ending way point of segment
unique_identifier_msgs/UUID start # beginning way point of segment
unique_identifier_msgs/UUID end # ending way point of segment

KeyValue[] props # segment properties
2 changes: 1 addition & 1 deletion geographic_msgs/msg/WayPoint.msg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Way-point element for a geographic map.

uuid_msgs/UniqueID id # Unique way-point identifier
unique_identifier_msgs/UUID id # Unique way-point identifier
GeoPoint position # Position relative to WGS 84 ellipsoid
KeyValue[] props # Key/value properties for this point
8 changes: 4 additions & 4 deletions geographic_msgs/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,21 @@
<url type="repository">https://github.com/ros-geographic-info/geographic_info.git</url>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>geometry_msgs</build_depend>
<build_depend>std_msgs</build_depend>
<build_depend>uuid_msgs</build_depend>
<build_depend>unique_identifier_msgs</build_depend>

<exec_depend>message_runtime</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>std_msgs</exec_depend>
<exec_depend>uuid_msgs</exec_depend>
<exec_depend>unique_identifier_msgs</exec_depend>

<member_of_group>rosidl_interface_packages</member_of_group>
<buildtool_depend>rosidl_default_generators</buildtool_depend>
<exec_depend>rosidl_default_runtime</exec_depend>

<export>
<build_type>ament_cmake</build_type>
<ros1_bridge mapping_rules="geographic_msgs_mapping_rule.yaml" />
</export>
</package>
6 changes: 3 additions & 3 deletions geographic_msgs/srv/GetGeoPath.srv
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ string status # more details

geographic_msgs/GeoPath plan # path to follow

uuid_msgs/UniqueID network # the uuid of the RouteNetwork
uuid_msgs/UniqueID start_seg # the uuid of the starting RouteSegment
uuid_msgs/UniqueID goal_seg # the uuid of the ending RouteSegment
unique_identifier_msgs/UUID network # the uuid of the RouteNetwork
unique_identifier_msgs/UUID start_seg # the uuid of the starting RouteSegment
unique_identifier_msgs/UUID goal_seg # the uuid of the ending RouteSegment
float64 distance # the length of the plan
6 changes: 3 additions & 3 deletions geographic_msgs/srv/GetRoutePlan.srv
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
#
# Similar to nav_msgs/GetPlan, but constrained to use the route network.

uuid_msgs/UniqueID network # route network to use
uuid_msgs/UniqueID start # starting way point
uuid_msgs/UniqueID goal # goal way point
unique_identifier_msgs/UUID network # route network to use
unique_identifier_msgs/UUID start # starting way point
unique_identifier_msgs/UUID goal # goal way point

---

Expand Down