changing uuid_msgs/UniqueID to unique_identifier_msgs/UUID

[mlautman]

No description provided.

[bmagyar]

I am not sure which one of us @ros-geographic-info/developers is working on ROS2 but the changes themselves look good to me.

I'll refrain from merging though until further notice :)

[mikaelarguedas]

@bmagyar When the time for merging this has come, could you please consider reviewing/merging #23 before applying this to remove unused code before updating it?

[klintan]

Any news on this one ?

[klintan]

@mlautman I tried this out with robot_localization and I got a dynamic linking error, related to Connext (which should be an optional middleware)

dyld: Library not loaded: @loader_path/libnddsc.dylib
  Referenced from: /ros2/ros2-osx/lib/librosidl_typesupport_connext_c.dylib
  Reason: image not found

I think it is related to all these exported dependencies, I don't think it should be exported, only ament_export_dependencies(rosidl_default_runtime) ? At least it seemed to work in robot_localization when only that is exported.

ament_export_dependencies(ament_cmake)
ament_export_dependencies(std_msgs)
ament_export_dependencies(geometry_msgs)
ament_export_dependencies(unique_identifier_msgs)
ament_export_dependencies(rosidl_default_generators)
ament_export_dependencies(rosidl_default_runtime)

Maybe you'll want to investigate/fix that in this PR before merge.

[IanTheEngineer]

It is used with the ros1_bridge to allow for communcation between ROS 1 and ROS 2.

nit sp. communication

[klintan]

Any chance we could get this one going ? It's a dependency of robot_localization navsat_transform_node and not having it released for ROS2 complicates things. Let me know if there is anything I can do to push these ROS2 PRs forward.

[SteveMacenski]

@mlautman closing after geographic-info ros2 branch update #28 which takes care of it.

I see you have a file for ROS1->2 conversion, if that's still required, I'd merge a PR with that.

[mlautman]

Sorry for falling off the face of the earth for a bit there. I am glad to see that #28 got merged.

Feel free to take the conversion.yaml and put it in another PR