Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irb2400 ikfast plugin fails to build after groovy update #1

Closed
jrgnicho opened this issue Jul 25, 2013 · 3 comments
Closed

irb2400 ikfast plugin fails to build after groovy update #1

jrgnicho opened this issue Jul 25, 2013 · 3 comments
Assignees

Comments

@jrgnicho
Copy link
Member

update in groovy changed the function signatures of the kinematics_base.h file. As a result, the irb_2400_manipulator_ikfast_moveit_plugin.cpp fails to build since it can't find any implementation of the base class' virtual methods. Will create a branch for this issue

@ghost ghost assigned jrgnicho Jul 25, 2013
@shaun-edwards
Copy link
Member

Jeremy is aware of this bug as well. You might want to talk to him about it.

@JeremyZoss
Copy link
Member

See changes they made to the moveit ikfast templates that probably address this same API change (8230ace255bfcc23665ddf6aa894e76858870b9e, e0d1b58e05da5a39e4a428ed654c81d83651864e). That plugin seems to totally ignore the parameter, though.

I think the right response is to update the API to match the new signatures and then replace any references to "lock_redundant_joints" with "options.lock_redundant_joints". We may also consider checking for "options.return_approximate_solution" and logging a WARN_ONCE if called with that unsupported option.

Long-term, the better answer is to probably re-generate the ABB plugin from the "official" moveit_ikfast template generator, to keep things consistent when changes are made in the future.

@shaun-edwards
Copy link
Member

Does this bug affect the released version of ABB (i.e. the google code version that the debs are built from)? If so can you please back port the fix to the google code groovy branch as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants