Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for CRX-10iA/L #67

Merged

Conversation

demorise
Copy link
Contributor

@demorise demorise commented Feb 14, 2022

Adding support for the crx10iA/L cobot. I realized someone tried to do this in the past but couldn't get through with it due to formatting issues. I have tried as much as possible to be consistent with other support packages in the repository. We have used the URDF succesfully with our cobot and the R30iB mini plus controller without any modifications to the fanuc ROS driver.

@gavanderhoorn

crx10_collision_model

@gavanderhoorn
Copy link
Member

Thanks for the PR. It's certainly appreciated.

I've been rather busy with other things. I'll take a look at a later time.

@gavanderhoorn
Copy link
Member

I've pushed a few fixup commits and submitted a PR @demorise.

See WILDER-SYSTEMS-LLC#1.

@demorise
Copy link
Contributor Author

I've pushed a few fixup commits and submitted a PR @demorise.

See WILDER-SYSTEMS-LLC#1.

Thanks @gavanderhoorn . Is there any action I need to take from my end?

@gavanderhoorn
Copy link
Member

If you agree with my proposed changes, you could merge the PR.

@gavanderhoorn gavanderhoorn changed the title Adding support for crx10ial Adding support for CRX-10iA/L Mar 30, 2022
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments.

fanuc_experimental/package.xml Outdated Show resolved Hide resolved
fanuc_crx10ia_support/package.xml Show resolved Hide resolved
fanuc_crx10ia_support/readme.md Outdated Show resolved Hide resolved
fanuc_crx10ia_support/readme.md Outdated Show resolved Hide resolved
@demorise
Copy link
Contributor Author

I have made the changes and pushed a new commit.

@gavanderhoorn
Copy link
Member

For your next PR: Github makes accepting suggestions really easy. Just click the button(s) in the comments in the web ui.

@gavanderhoorn
Copy link
Member

Apparently Actions needed a nudge.

@demorise
Copy link
Contributor Author

For your next PR: Github makes accepting suggestions really easy. Just click the button(s) in the comments in the web ui.

Thanks!

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this looks OK now.

Thanks again for the PR @demorise, and thanks for iterating on it with me.

👍

@gavanderhoorn
Copy link
Member

I'll use a squash-merge, as we don't need all the fixups to end up in the repository's commit history.

@gavanderhoorn gavanderhoorn merged commit 76bfe55 into ros-industrial:melodic-devel Mar 30, 2022
@gavanderhoorn
Copy link
Member

Thanks again @demorise.

Note that because I used a squash-merge, Github may not let you know you can delete the branch.

@demorise
Copy link
Contributor Author

Thanks again @demorise.

Note that because I used a squash-merge, Github may not let you know you can delete the branch.

No worries!

@demorise demorise deleted the crx10ial_support branch March 30, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants