New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for CRX-10iA/L #67
Adding support for CRX-10iA/L #67
Conversation
Thanks for the PR. It's certainly appreciated. I've been rather busy with other things. I'll take a look at a later time. |
So don't list the specs.
Avoid potential clashes.
Makes it easier to compare joint limits to documentation.
I've pushed a few fixup commits and submitted a PR @demorise. See WILDER-SYSTEMS-LLC#1. |
Thanks @gavanderhoorn . Is there any action I need to take from my end? |
If you agree with my proposed changes, you could merge the PR. |
…support A couple of fixups (context: ros-industrial#67)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments.
I have made the changes and pushed a new commit. |
For your next PR: Github makes accepting suggestions really easy. Just click the button(s) in the comments in the web ui. |
Apparently Actions needed a nudge. |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this looks OK now.
Thanks again for the PR @demorise, and thanks for iterating on it with me.
👍
I'll use a squash-merge, as we don't need all the fixups to end up in the repository's commit history. |
Thanks again @demorise. Note that because I used a squash-merge, Github may not let you know you can delete the branch. |
No worries! |
Adding support for the crx10iA/L cobot. I realized someone tried to do this in the past but couldn't get through with it due to formatting issues. I have tried as much as possible to be consistent with other support packages in the repository. We have used the URDF succesfully with our cobot and the R30iB mini plus controller without any modifications to the fanuc ROS driver.
@gavanderhoorn