Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for R-2000iC/210L #70

Merged
merged 5 commits into from Apr 1, 2022
Merged

Adding support for R-2000iC/210L #70

merged 5 commits into from Apr 1, 2022

Conversation

demorise
Copy link
Contributor

@gavanderhoorn Here is the new PR for the 210L based off melodic-devel. Replaces #69
fanuc_2000ic_210l
Test results:
tf_echo
teach_pendant_tf

@demorise demorise mentioned this pull request Mar 30, 2022
Closed
@gavanderhoorn gavanderhoorn changed the title Adding support for R2000ic/210L Adding support for R-2000iC/210L Mar 30, 2022
@gavanderhoorn
Copy link
Member

Thanks.

I'll take a look.

@gavanderhoorn gavanderhoorn reopened this Mar 30, 2022
gavanderhoorn
gavanderhoorn requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial round of comments.

fanuc_r2000ic_support/CMakeLists.txt Show resolved Hide resolved
fanuc_r2000ic_support/package.xml Outdated Show resolved Hide resolved
fanuc_r2000ic_support/package.xml Show resolved Hide resolved
fanuc_r2000ic_support/package.xml Outdated Show resolved Hide resolved
fanuc_r2000ic_support/tests/roslaunch_test_r2000ic10l.xml Outdated Show resolved Hide resolved
fanuc_r2000ic_support/urdf/r2000ic210l_macro.xacro Outdated Show resolved Hide resolved
gavanderhoorn
gavanderhoorn approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I've fixed the last few outstanding issues.

@gavanderhoorn gavanderhoorn merged commit faf8a75 into ros-industrial:melodic-devel Apr 1, 2022
@gavanderhoorn
Copy link
Member

Thanks again @demorise 👍

Just as with #67, I've used a squash-merge.

It could be that Github doesn't show you the "you can delete this branch" button again.

@demorise
Copy link
Contributor Author

demorise commented Apr 1, 2022

Thanks @gavanderhoorn for the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@demorise @gavanderhoorn