reduce verbosity

[rhaschke]

Travis has a log limit in the web interface (10k lines), which is easily exceeded by MoveIt. This PR disables shell debugging when sourcing ROS' setup.bash and removes --verbose mode from catkin calls.

The first commit 7276921 removes a git diff command that causes the following error:

++++git diff origin/master FETCH_HEAD .ci_config
fatal: ambiguous argument 'origin/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

What was the purpose of this?

[130s]

Thanks for the feedback. I'll have to come back later to take a closer look but would #43 work for you in terms of verbosity?

[rhaschke]

Thinking more about the issue, I came to the conclusion that it is hard to server the two goals of i) printing the commands from travis.sh but ii) not printing the commands in called functions or sourced scripts.
The output in the web interface is cluttered already in the overview (with travis_time_start, set +x, and <<< >>>. Hence, for MoveIt, I resumed to standard travis.yml files, improving them according to some inspiration gained from your script. I like the result much better - but that's my subjective view of course.

Regarding your work, I have the following suggestions:

• Consider removing the options -i -v completely. The new catkin tools 0.4 does a pretty good job of hiding boring information (everything works as expected) but showing important stuff (warnings and errors).
• Consider building to install space directly. I don't see a reason why to build twice, for devel and install space. This only doubles the response time of the test.

[130s]

I came to the conclusion that it is hard to server the two goals of i) printing the commands from travis.sh but ii) not printing the commands in called functions or sourced scripts.
The output in the web interface is cluttered already in the overview (with travis_time_start, set +x, and <<< >>>. Hence, for MoveIt, I resumed to standard travis.yml files, improving them according to some inspiration gained from your script. I like the result much better - but that's my subjective view of course.

That's a valuable feedback. I like to integrate those to industrial_ci, which is aiming to free package maintainers from maintaining CI configurations, unless they want to.

[rhaschke]

I like to integrate those to |industrial_ci|, which is aiming to free
package maintainers from maintaining CI configurations, unless they
want to.
Indeed, this approach is appealing and I like it. But one needs to find
a better way to integrate with the Travis config. What about including
yml into yml? Is that possible?

[130s]

Thanks for the PR and also suggestions. I'm following them up in #54 and #55.

Speaking of the number of the lines, I think #43 is already doing a good job and a nice thing about #43 is it gives verbose option so that if you need more output you always can print more (good for debugging).

So I close this for now in favor of #43, but please feel free to reopen if you have further updates.

[davetcoleman]

Consider removing the options -i -v completely. The new catkin tools 0.4 does a pretty good job of hiding boring information (everything works as expected) but showing important stuff (warnings and errors).

+1

[davetcoleman]

I like the changes in this closed PR...