-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Error for simple_message on "add_dependencies" #12
Comments
AFAICT the fix for the referenced #4 is ok, it just seems to depend on a >= version of Comment on specific version of Note that the catkin docs add a dependency on I propose we create branches to those we had in the googlecode project, to prevent this sort of thing ( |
Just checked:
Seems like the current groovy version of |
I'm hesitant to create a hydro branch since it would require constant syncing to the groovy branch (which might be easier in git, but was painful in svn). Most developers are still on groovy since it is stable and there wasn't a clear reason to move to hydro (especially with no official release date in sight). You appear to be using Hydro. Can you make a case for switching sooner rather than later (a good enough case to have to manage multiple branches?) My preference is to stick to groovy and just log bugs against a hydro release. |
Well, I don't think I have a case 'for Hydro' other than that it seems prudent to start supporting it as soon as possible. As soon as the catkinization of industrial_core is good enough, supporting Hydro shouldn't be too hard. Keeping the branches synced shouldn't be that much of a problem. If we're not going to support Hydro in this repository, you should edit the readme: it currently states that the github repository is for > groovy, while the googlecode project is for <= groovy. |
Christina, Can you move ahead with creating a groovy-dev and hydro-dev branch in this repo. Make sure the CMakeLists has the appropriate changes in each. We will use this as an experiment to determine how good git is at managing two development paths. We may want to consider deleting the master branch since this causes confusion, but we will wait for that change. |
May I suggest naming the branches |
I'm not tied to the name. We used -dev in the subversion repo. We will leave it up to Christina to decide. |
Ok groovy-devel and hydro-devel branches created. The groovy branch has the fix that I did (${PROJECT_NAME}_gencpp) and the hydro branch has the preferred method (${PROJECT_NAME}_EXPORTED_TARGETS). |
Upon cloning the industrial_core repo into my catkin workspace, catkin_make gave the following error:
The error appeared three times for the three add_dependencies lines, one example below:
I changed the ${industrial_msgs_EXPORTED_TARGETS} to simple_message_gencpp and was able to complete the make process.
I'm guessing maybe there's a setting/configuration I missed somewhere, but I'm not sure.
The text was updated successfully, but these errors were encountered: