Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming yrcmlib to correct yrcmLib filename extension. #526

Merged
merged 1 commit into from Nov 18, 2022
Merged

Renaming yrcmlib to correct yrcmLib filename extension. #526

merged 1 commit into from Nov 18, 2022

Conversation

fgrcar
Copy link
Contributor

@fgrcar fgrcar commented Nov 18, 2022

Because of the wrong filename extension, the MotoPlus IDE didn't link the library file into the output file and therefore the robot displayed the missing symbols error when executing the app. From my point of view, this is a terrible bug on which I spent days. Finally I was managed to resolve it when the local Yaskawa programmer pointed it out.

@gavanderhoorn
Copy link
Member

While technically correct, Windows is not case-sensitive, so I'm confused as to how this could be a problem.

It could be the compiler/linker used is case sensitive though.

@gavanderhoorn gavanderhoorn added the motoros Issues specifically about MotoROS label Nov 18, 2022
@fgrcar
Copy link
Contributor Author

fgrcar commented Nov 18, 2022

Yeah, I don't know, but until I changed it, even the IDE didn't show the library file under the library files' section. I realized that the out file is exactly that smaller in size as is the size of the library file, so I exactly knew what is wrong but wasn't able to fix it at the first place. Anyway, after the filename extension correction, it worked as expected.

@ted-miller
Copy link
Contributor

Can you please clarify whether you are using MotoPlusIDE or Visual Studio?

This is MPIDE:
image

ted-miller
ted-miller approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of whether windows should care about case, it is technically correct that the L should be capitalized.

@gavanderhoorn gavanderhoorn merged commit 828411f into ros-industrial:kinetic-devel Nov 18, 2022
@gavanderhoorn
Copy link
Member

Thanks @fgrcar 👍

@fgrcar
Copy link
Contributor Author

fgrcar commented Nov 18, 2022

@ted-miller: MotoPlus IDE, yes, as I wrote in my first comment.
Thank you guys for such quick response, I'm glad to help.

cjue pushed a commit to isys-vision/motoman that referenced this pull request Nov 22, 2022
@fgrcar @cjue
Renaming yrcmlib to correct yrcmLib filename extension. (ros-industri…
90fee6f 
…al#526)

Co-authored-by: Filip Grcar <filip.grcar@airnamics.com>
jmarsik added a commit to jmarsik/motoman that referenced this pull request Mar 25, 2024
@jmarsik
Merge remote-tracking branch 'github-upstream/kinetic-devel' into kmr…
464fb6c 
…-multigroup

(mainly FSU related changes in motoman_driver MotoPlus part)

* github-upstream/kinetic-devel:
  Update version to 1.9.12
  Removed binary files
  Removed binary output file
  Correction following Ted's review
  Change color of model motors to dark gray
  Change color of model motors to dark gray
  Fix last commit error
  Update MotionServer.c
  Added comments
  Compiled new binary
  Fix unwanted motion when switching pendant mode
  Reset of hasUnprocessedData
  Reset Speed Limit related variables when robot is not under ROS motion control
  apply suggestions by gavanderhoorn, fix HC10DTP-B00 model name
  remove IDE file
  Correction of the model name to -b00
  Add support for HC10DTP
  Add job for `R1R*R*R*S*S1S2S3` configuration (ros-industrial#540)
  Update readme to highlight the fact that this is ROS 1 (ros-industrial#549)
  Motoman GP70L Support
  Change to support DX100
  restructure eco-clear code
  Update binaries
  Fix automatic `robot_enable`  based on testing
  Fix for ros-industrial#492
  increment version number
  fix for ros-industrial#519
  Delete MotoRosYRC1u_1910.out
  Added MotoRosYRC1u_,out
  Updated prevPulsePosData for all control groups
  Added multiple control group support
  Added basic FSU Speed Limit Handling
  GP35L Support Package
  Fix ES200-120 joint S limit (ros-industrial#534)
  ci: bump checkout and cache (ros-industrial#529)
  Renaming yrcmlib to correct yrcmLib filename extension. (ros-industrial#526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

@ted-miller ted-miller ted-miller approved these changes

Assignees
No one assigned
Labels
motoros Issues specifically about MotoROS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgrcar @gavanderhoorn @ted-miller