Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for MPP3H kinematic library and support #20

Open
wants to merge 1 commit into
base: kinetic-devel
Choose a base branch
from

Conversation

Chamango90
Copy link

Kinematic library and support package for the Motoman MPP3H delta robot.

@gavanderhoorn
Copy link
Member

Should this go into kinetic-devel? From the commits included I think you use kinetic-devel on your machine, but opened the PR against indigo-devel?

@Chamango90
Copy link
Author

Rebased to indigo-devel.

@mathias-luedtke
Copy link
Member

test config is missing. @gavanderhoorn: should I provide one?

@@ -0,0 +1 @@
*.txt.user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should get dropped.

@gavanderhoorn
Copy link
Member

@ipa-mdl wrote:

test config is missing. @gavanderhoorn: should I provide one?

thanks for the offer, but I think it'd be better if this PR would be targeted at kinetic-devel. We already have Travis set up there, and this repo doesn't really see any development for Indigo.

@ipa-jfh: would it be a big problem for you to submit against kinetic-devel? You don't need to re-open the PR, you could just edit it (top of the page).

@Chamango90 Chamango90 changed the title Mpp3h Initial commit for MPP3H kinematic library and support May 11, 2017
@Chamango90 Chamango90 changed the base branch from indigo-devel to kinetic-devel May 11, 2017 15:02
@Chamango90
Copy link
Author

Chamango90 commented May 11, 2017

I could not test this packages on kinetic. @gavanderhoorn: Could you please make a quick test with test_mpp3h.launch of motoman_mpp3h_support?

@gavanderhoorn
Copy link
Member

I can probably run it in a Docker container. I don't have the hardware though.

Do you have any experience with Docker? I (or maybe @ipa-mdl) could probably help you get to a point where you can run your package under Kinetic on a Trusty system.

@gavanderhoorn
Copy link
Member

Btw: Travis is failing now because your install(..) line is trying to install a config dir that doesn't exist.

@mathias-luedtke
Copy link
Member

mathias-luedtke commented May 11, 2017

@gavanderhoorn: We don't have the hardware anymore, the test_mpp3h.launch just starts a joint_state_publisher and RVIZ.

@Chamango90
Copy link
Author

Btw: Travis is failing now because your install(..) line is trying to install a config dir that doesn't exist.

Thank you. I fixed the install line.

@gavanderhoorn
Copy link
Member

@ipa-mdl wrote:

@gavanderhoorn: We don't have the hardware anymore, [..]

so we can't actually test any changes that might be necessary after review of the current code then?

@mathias-luedtke
Copy link
Member

so we can't actually test any changes that might be necessary after review of the current code then?
Show all checks

Yes, we cannot test it properly with the hardware. But the code is about the kinematics and it can be tested without the hardware :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants