catkin_create_pkg should fill system deps and CATKIN_DEPENDS

[tkruse]

The new CATKIN_DEPENDS and DEPENDS cmake macro arg should be initialized by default

I imagine we could extend the create script so that this syntax:

catkin_create_pkg foo roscpp --system BZip2 --boost thread regex

creates this CMakeLists.txt snippets:

find_package(catkin REQUIRED COMPONENTS roscpp)
find_package(Boost REQUIRED COMPONENTS regex thread)
find_package(BZip2 REQUIRED)
catkin_package(
  # INCLUDE_DIRS include
  # CATKIN-DEPENDS roscpp
  # DEPENDS BZip2
  )
# target_link_libraries(rosbag 
#     ${catkin_LIBRARIES}
#     ${Boost_LIBRARIES} 
#     ${BZIP2_LIBRARIES})

Dirk to advise whether the above example is correct and makes sense.

I can create a pull request if others agree.

[wjwwood]

cc: @dirk-thomas

[dirk-thomas]

Yes, the example makes sense. One thing which is missing is that Boost should also be passed as DEPENDS (like BZip2). I guess the template also has a line with include_directories() with all the variable from the found projects?

Another point may be that the name of the depending package might not be equal to the name which needs to be find_package()-ed. But adding it 1-to-1 is still a good thing in the template - the user can always modify it if necessary.

[tkruse]

working on a pull request...

[tkruse]

changes included in #19
now also suggests values for include_directories as Dirk suggested (and several other features)

[tkruse]

on second thought, created a separate pull request #21 for this

[tkruse]

was implemented