Review revisions rep-2004 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maryaB-osr <marya@openrobotics.org>
wjwwood
approved these changes
Mar 24, 2020
wjwwood
added a commit
that referenced
this pull request
May 5, 2020
* initial commit of new rep-2004 Signed-off-by: William Woodall <william@osrfoundation.org> * update my (wjwwood's) email addresses, because the rep script only allows one per person Signed-off-by: William Woodall <william@osrfoundation.org> * fixup copyright/license statements Signed-off-by: William Woodall <william@osrfoundation.org> * REP 2004 extras (#235) * REP 2004 extras Signed-off-by: maryaB-osr <marya@openrobotics.org> * possible chart structure and license question Signed-off-by: maryaB-osr <marya@openrobotics.org> * comment out chart Signed-off-by: maryaB-osr <marya@openrobotics.org> * restructure and edits Signed-off-by: maryaB-osr <marya@openrobotics.org> * fixed a header Signed-off-by: maryaB-osr <marya@openrobotics.org> * add chart Signed-off-by: maryaB-osr <marya@openrobotics.org> * q. level 3 testing in wrong order Signed-off-by: maryaB-osr <marya@openrobotics.org> * level 3 3.v.a mistake Signed-off-by: maryaB-osr <marya@openrobotics.org> * moved chart to be under level 1 makes it easier to read the numbers Signed-off-by: maryaB-osr <marya@openrobotics.org> * wjwwood review Signed-off-by: maryaB-osr <marya@openrobotics.org> * edits / chart check Signed-off-by: maryaB-osr <marya@openrobotics.org> * fix python incompatibility Signed-off-by: maryaB-osr <marya@openrobotics.org> * mention level 5 in specification intro; fix typos Signed-off-by: William Woodall <william@osrfoundation.org> * Review revisions rep-2004 (#243) Signed-off-by: maryaB-osr <marya@openrobotics.org> * Add item numbers to quality declaration template (#244) * Add item numbers to quality declaration template Signed-off-by: maryaB-osr <marya@openrobotics.org> * list all requirements Signed-off-by: maryaB-osr <marya@openrobotics.org> * link to requirements in chart Signed-off-by: maryaB-osr <marya@openrobotics.org> * fix list indentation Signed-off-by: maryaB-osr <marya@openrobotics.org> * Add security section (#247) Signed-off-by: Kyle Fazzari <kyle@canonical.com> * Update rep-2004.rst Co-Authored-By: Alejandro Hernández Cordero <ahcorde@gmail.com> * Update rep-2004.rst Co-Authored-By: Marya Belanger <marya@openrobotics.org> * Update rep-2004.rst Co-Authored-By: Kyle Fazzari <github@status.e4ward.com> * Adjusting 3.v.b requirement (#253) Signed-off-by: maryaB-osr <marya@openrobotics.org> * Optional chart symbol + "higher quality" distinction * address feedback about copyright statement requirements Signed-off-by: William Woodall <william@osrfoundation.org> Co-authored-by: Marya Belanger <marya@openrobotics.org> Co-authored-by: Kyle Fazzari <github@status.e4ward.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworded platform support section to be ROS 1 inclusive.
Recommend license declaration for level 5.
Signed-off-by: maryaB-osr marya@openrobotics.org