Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting 3.v.b requirement #253

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Adjusting 3.v.b requirement #253

merged 1 commit into from
Apr 29, 2020

Conversation

maryaB-osr
Copy link
Contributor

#218 (comment)

Signed-off-by: maryaB-osr marya@openrobotics.org

Signed-off-by: maryaB-osr <marya@openrobotics.org>
@maryaB-osr maryaB-osr requested a review from wjwwood April 29, 2020 07:23
Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@wjwwood wjwwood merged commit 0282e1c into rep-2004 Apr 29, 2020
@wjwwood wjwwood deleted the maryaB/3.v.b branch April 29, 2020 15:29
wjwwood added a commit that referenced this pull request May 5, 2020
* initial commit of new rep-2004

Signed-off-by: William Woodall <william@osrfoundation.org>

* update my (wjwwood's) email addresses, because the rep script only allows one per person

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixup copyright/license statements

Signed-off-by: William Woodall <william@osrfoundation.org>

* REP 2004 extras (#235)

* REP 2004 extras

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* possible chart structure and license question

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* comment out chart

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* restructure and edits

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* fixed a header

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* add chart

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* q. level 3 testing in wrong order

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* level 3 3.v.a mistake

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* moved chart to be under level 1

makes it easier to read the numbers

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* wjwwood review

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* edits / chart check

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* fix python incompatibility

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* mention level 5 in specification intro; fix typos

Signed-off-by: William Woodall <william@osrfoundation.org>

* Review revisions rep-2004 (#243)

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* Add item numbers to quality declaration template (#244)

* Add item numbers to quality declaration template

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* list all requirements

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* link to requirements in chart

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* fix list indentation

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* Add security section (#247)

Signed-off-by: Kyle Fazzari <kyle@canonical.com>

* Update rep-2004.rst

Co-Authored-By: Alejandro Hernández Cordero <ahcorde@gmail.com>

* Update rep-2004.rst

Co-Authored-By: Marya Belanger <marya@openrobotics.org>

* Update rep-2004.rst

Co-Authored-By: Kyle Fazzari <github@status.e4ward.com>

* Adjusting 3.v.b requirement (#253)

Signed-off-by: maryaB-osr <marya@openrobotics.org>

* Optional chart symbol

+ "higher quality" distinction

* address feedback about copyright statement requirements

Signed-off-by: William Woodall <william@osrfoundation.org>

Co-authored-by: Marya Belanger <marya@openrobotics.org>
Co-authored-by: Kyle Fazzari <github@status.e4ward.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants