Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ros-tooling GitHub Action CI to REP-2005 #299

Merged
merged 2 commits into from Mar 19, 2021
Merged

Add ros-tooling GitHub Action CI to REP-2005 #299

merged 2 commits into from Mar 19, 2021

Conversation

emersonknapp
Copy link
Contributor

Justification:

  • Gaining usage across ecosystem
  • Helps packages attain some REP-2004 quality bars easily and freely
  • Has its own CI and unit testing

Add ros-tooling GitHub Action CI to REP-2005
ed730df 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-12-17/18182/1

@clalancette
Copy link
Contributor

We've got 3 approvals, so I'm going to go ahead and merge (travis CI may eventually succeed, but I'm not going to wait for it).

@clalancette clalancette merged commit 0defa07 into ros-infrastructure:master Mar 19, 2021
@emersonknapp emersonknapp deleted the 2005-add-gh-action-ci branch July 4, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@ablasdel ablasdel ablasdel approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emersonknapp @ros-discourse @clalancette @ablasdel @Karsten1987