Add ddebs to published binarydeb files. #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddebs containing debug symbols stripped from binary packages are being generated by default for artful and bionic. Reprepro cannot ingest ddeb files so we removed them from the changes file in reprepro updater (see ros-infrastructure/reprepro-updater#55). Since we would like to provide debug symbols we've found a slightly different approach: renaming the ddeb file to a regular deb (see ros-infrastructure/reprepro-updater#60). In order for that to work, we actually need to publish the ddeb to the repo host with the other files. I opted to publish it as a ddeb and rename it at import time so that no changes need to be made to ros_buildfarm if we change the handling in the future.
dirk-thomas
approved these changes
May 22, 2018
clalancette
approved these changes
May 22, 2018
|
@clalancette and I have decided to wait on merging this PR, and thus ros-infrastructure/reprepro-updater#60 as well, until the initial melodic release has been completed. It's been tested on specific melodic packages that I think cover each combination of ddeb files present or not. But I haven't had it deployed during long comprehensive distro rebuilds or for older rosdistros that never produce dbgsym/ddeb packages. So this will keep until the release sync is completed after which it is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddebs containing debug symbols stripped from binary packages are being generated by default for artful and bionic. Reprepro cannot ingest ddeb files so we removed them from the changes file in reprepro updater (see ros-infrastructure/reprepro-updater#55).
Since we would like to provide debug symbols we've found a slightly different approach: renaming the ddeb file to a regular deb (see ros-infrastructure/reprepro-updater#60).
In order for that to work, we actually need to publish the ddeb to the repo host with the other files. I opted to publish it as a ddeb and rename it at import time so that no changes need to be made to ros_buildfarm if we change the handling in the future.
This change needs to merge before ros-infrastructure/reprepro-updater#60. If merged with the current behavior the transferred ddeb will just be ignored.