New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use colcon instead of catkin_make_isolated #548

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dirk-thomas
Member

dirk-thomas commented May 30, 2018

For now the patch avoids any kind of renaming to keep it as close to master as possible.

@@ -61,6 +61,10 @@ def main(argv=sys.argv[1:]):
if args.parent_result_space:
parent_result_spaces = args.parent_result_space
# TODO try to remove melodic from this list
use_merge_install = args.rosdistro_name in (
'indigo', 'jade', 'kinetic', 'lunar', 'melodic')

This comment has been minimized.

@mikaelarguedas

mikaelarguedas Jun 8, 2018

Contributor

Can we remove jade from that list as well as it's been EOL for year?

This comment has been minimized.

@dirk-thomas

dirk-thomas Jun 8, 2018

Member

We could but I don't see a need for it. If anyone would still run a Jade buildfarm keeping the entry will ensure to not change the behavior.

@dirk-thomas

This comment has been minimized.

Member

dirk-thomas commented Jun 8, 2018

The current state of the patch seems solid enough to build the ROS 1 devel jobs minus the differences of cmi in terms of accessing resources from the source space of other packages in the repo (see ros-infrastructure/ros_buildfarm_config#117 (comment)).

I will rewrite the changes into a small set of easier to review commits...

I extracted an unrelated fix in #552.

@mikaelarguedas

This comment has been minimized.

Contributor

mikaelarguedas commented Sep 17, 2018

@dirk-thomas Running some prerelease jobs I faced a few things that impacted user experience:

@dirk-thomas

This comment has been minimized.

Member

dirk-thomas commented Oct 24, 2018

if colcon is not sourced / on the path it just prints colcon command not found

This has been address in #585 printing a similar error message as for catkin_make_isolated.

No indicator of the progress of the builds, is the status line expected to be printed ?

The status line is not expected to be printed since it is only enabled when using an interactive shell. But you should still see the progress of the build (start / finish messages per package as well as the output of the build). Please try again with #585 and comment in which exact scenario you don't see any progress.

@dirk-thomas

This comment has been minimized.

Member

dirk-thomas commented Oct 24, 2018

This PR has been superseded by #585 and will be closed once the existing jobs have been transitioned to the new PR (or to master after it has been merged).

@dirk-thomas

This comment has been minimized.

Member

dirk-thomas commented Nov 9, 2018

The Bouncy devel jobs have been reconfigured to use the master branch.

@dirk-thomas dirk-thomas closed this Nov 9, 2018

@dirk-thomas dirk-thomas deleted the use_colcon branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment