use colcon instead of catkin_make_isolated #548
Conversation
dirk-thomas
force-pushed
the
use_colcon
branch
6 times, most recently
from
dc9816a
to
72b8678
Compare
| @@ -61,6 +61,10 @@ def main(argv=sys.argv[1:]): | |||
| if args.parent_result_space: | |||
| parent_result_spaces = args.parent_result_space | |||
|
|
|||
| # TODO try to remove melodic from this list | |||
| use_merge_install = args.rosdistro_name in ( | |||
| 'indigo', 'jade', 'kinetic', 'lunar', 'melodic') | |||
There was a problem hiding this comment.
Can we remove jade from that list as well as it's been EOL for year?
There was a problem hiding this comment.
We could but I don't see a need for it. If anyone would still run a Jade buildfarm keeping the entry will ensure to not change the behavior.
|
The current state of the patch seems solid enough to build the ROS 1 devel jobs minus the differences of cmi in terms of accessing resources from the source space of other packages in the repo (see ros-infrastructure/ros_buildfarm_config#117 (comment)). I will rewrite the changes into a small set of easier to review commits... I extracted an unrelated fix in #552. |
dirk-thomas
force-pushed
the
use_colcon
branch
5 times, most recently
from
1d5ad61
to
d9d077d
Compare
|
@dirk-thomas Running some prerelease jobs I faced a few things that impacted user experience:
|
This has been address in #585 printing a similar error message as for
The status line is not expected to be printed since it is only enabled when using an interactive shell. But you should still see the progress of the build (start / finish messages per package as well as the output of the build). Please try again with #585 and comment in which exact scenario you don't see any progress. |
|
This PR has been superseded by #585 and will be closed once the existing jobs have been transitioned to the new PR (or to master after it has been merged). |
|
The Bouncy devel jobs have been reconfigured to use the |
For now the patch avoids any kind of renaming to keep it as close to master as possible.