Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noetic blacklist cob_monitoring #187

Merged
merged 1 commit into from Dec 3, 2020
Merged

Noetic blacklist cob_monitoring #187

merged 1 commit into from Dec 3, 2020

Conversation

sloretz
Copy link

@sloretz sloretz commented Dec 3, 2020

https://answers.ros.org/question/366881/
https://github.com/ipa320/cob_command_tools/issues/289

Signed-off-by: Shane Loretz sloretz@openrobotics.org
Signed-off-by: Shane Loretz sloretz@osrfoundation.org

@fmessmer FYI this will stop the cob_monitorying buildfarm jobs for Noetic

@sloretz
Noetic blacklist cob_monitoring
f74c231 
https://answers.ros.org/question/366881/
https://github.com/ipa320/cob_command_tools/issues/289

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Dec 3, 2020
@fmessmer
Copy link

fmessmer commented Dec 3, 2020

great, thanks!

just one more question:
what about the downstream dependencies?
e.g. the cob_command_tools meta-package or other packages declaring a dependency on cob_monitoring?
do they need to get blacklisted, too?

I'm also getting similar mails for other cob_command_tools packages although only cob_monitoring has an unmet dependency on buster (as far as i can tell)
does this fix the build failure also for those jobs?

@cottsay
Copy link
Member

cottsay commented Dec 3, 2020

what about the downstream dependencies?

Any package which depends on an excluded package will also be excluded, so you should see those jobs get disabled as well.

@fmessmer
Copy link

fmessmer commented Dec 3, 2020

thanks for clarifying!

@sloretz sloretz merged commit a2f3ae8 into production Dec 3, 2020
@sloretz sloretz deleted the noetic_blacklist_cob_monitoring branch December 3, 2020 21:38
@fmessmer fmessmer mentioned this pull request Dec 8, 2020
Closed
@fmessmer
Copy link

fmessmer commented Dec 8, 2020

I still have issues with failure reports for other packages from the same cob_command_tools repository
I posted a follow-up question: https://answers.ros.org/question/366881/noetic-build-failed-in-jenkins-debianbuster-could-not-resolve-rosdep-key/?answer=367253#post-id-367253

@fmessmer fmessmer mentioned this pull request Dec 9, 2020
Closed
nuclearsandwich referenced this pull request in ros2/ros_buildfarm_config Dec 28, 2020
@sloretz @nuclearsandwich
Noetic blacklist cob_monitoring (#187)
ffa267a 
https://answers.ros.org/question/366881/
https://github.com/ipa320/cob_command_tools/issues/289

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
fmessmer added a commit to fmessmer/ros_buildfarm_config that referenced this pull request Jan 25, 2021
@fmessmer
Revert "Noetic blacklist cob_monitoring (ros-infrastructure#187)"
f392aa2 
This reverts commit a2f3ae8.
@fmessmer fmessmer mentioned this pull request Jan 29, 2021
Merged
sloretz pushed a commit that referenced this pull request Jan 29, 2021
@fmessmer
Revert "Noetic blacklist cob_monitoring (#187)" (#196)
cfa0935 
This reverts commit a2f3ae8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sloretz @fmessmer @cottsay