Remove build dependency on nose from setup.py #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having nose required to run setup.py is needed only to enable the `nosetests` command which is redundant since it duplicates the `test` command. Also it prevents building python-rosdep in build environments where external downloads during build time are prohibited in order to provide reproducible and more reliable builds. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having nose required to run setup.py is needed only to enable
the
nosetestscommand which is redundant since it duplicatesthe
testcommand. Also it prevents building python-rosdepin build environments where external downloads during build time
are prohibited in order to provide reproducible and more reliable
builds.
Signed-off-by: Dmitry Rozhkov dmitry.rozhkov@linux.intel.com