Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for 16UC1 image #150

Closed
wants to merge 4 commits into from
Closed

Conversation

lgeo3
Copy link

@lgeo3 lgeo3 commented Sep 17, 2015

It is usefull to calibrate xtion infrared channel on Pepper robot

It is usefull to calibrate xtion infrared channel on Pepper robot
@@ -237,6 +237,10 @@ def mkgray(self, msg):
Convert a message into a 8-bit 1 channel monochrome OpenCV image
"""
# as cv_bridge automatically scales, we need to remove that behavior
if msg.encoding=='16UC1':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge that condition with the one below to not have code duplication

Laurent GEORGE added 3 commits September 22, 2015 10:52
it's the same datatype behind (i.e uint16)
We just truncate, no rescale
int16_image = self.br.imgmsg_to_cv2(msg)
mono8 = numpy.array(128 + numpy.clip(int16_image, 0, 127), dtype=numpy.uint8)
return mono8
if msg.encoding in ['16UC1', 'mono16', '16UC16']:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16UC16 is not a valid format

@vrabaud
Copy link
Contributor

vrabaud commented Dec 3, 2015

ping

@vrabaud vrabaud closed this in 7383bd8 Jan 1, 2016
vrabaud added a commit to vrabaud/image_pipeline that referenced this pull request Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants