-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for 16UC1 image #150
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is usefull to calibrate xtion infrared channel on Pepper robot
@@ -237,6 +237,10 @@ def mkgray(self, msg): | |||
Convert a message into a 8-bit 1 channel monochrome OpenCV image | |||
""" | |||
# as cv_bridge automatically scales, we need to remove that behavior | |||
if msg.encoding=='16UC1': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please merge that condition with the one below to not have code duplication
it's the same datatype behind (i.e uint16)
We just truncate, no rescale
int16_image = self.br.imgmsg_to_cv2(msg) | ||
mono8 = numpy.array(128 + numpy.clip(int16_image, 0, 127), dtype=numpy.uint8) | ||
return mono8 | ||
if msg.encoding in ['16UC1', 'mono16', '16UC16']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16UC16 is not a valid format
ping |
vrabaud
added a commit
to vrabaud/image_pipeline
that referenced
this pull request
Jan 3, 2016
This re-uses ros-perception#150 and therefore closes ros-perception#150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is usefull to calibrate xtion infrared channel on Pepper robot