New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 409 based on melodic branch #411
Conversation
Using toCvCopy instead of toCvShared (copy is needed anyway).
Base fork on upstream melodic instead of indigo
I'm not familiar with |
@knorth55 |
@Tuebel - Since this is a back-port, can you also create a PR to apply any changes you make here to |
@Tuebel @JWhitleyAStuff |
@knorth55 I pushed an implementation, which allows to resize the image and the camera_info independently. The images are published and subscribed using the image_transport classes so we still get the functionality of the plugins. I also kept an eye on making only the necessary changes compared to the old resize.cpp. @JWhitleyAStuff I'm sorry but I don't understand what kind of different PR should I create? |
@Tuebel - Nevermind. I was confused. There are many tickets in-flight right now and I got them mixed up. |
Based #409 on branch melodic.
Also removed
boost::mutex
andboost::shared_ptr
in favor of the std types.The constructor of the
dynamic_reconfigure::Server
requires aboost::recursive_mutex
so in this version I use the constructor without the mutex parameter. But as far as I can tell from the code of the server the mutex is only required when callingdynamic_reconfigure::Server::updateConfig(const ConfigType &config)
which we don't.