Avoid crashing when the x or y offset is too large #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it optional to create blank image where there is no source image to be had.
JWhitleyWork
reviewed
Jul 8, 2019
SteveMacenski
requested changes
Jul 10, 2019
JWhitleyWork
approved these changes
Jul 19, 2019
SteveMacenski
approved these changes
Jul 19, 2019
|
@JWhitleyAStuff I approved, but I would really like those warnings throttled. After merge I might just submit a new PR to do that |
Sorry for resolving the issue. I misread the code. I thought they had been. My bad. |
|
@JWhitleyAStuff if you're happy with it, merge away, I cant PR my updates until this is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later should make it optional to create blank image where there is no source image to be had.
Also later need to respect the camera info roi of the incoming image, the crop coordinates should be relative to the uncropped incoming image, not the cropped one.