Minimal Noetic #530
Merged
Minimal Noetic #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
@clalancette Tests are still failing and I'm not familiar enough with the math behind the code to fix them. Would you mind taking a look? |
|
@JWhitleyWork the Circle builds are failing from lack of memory. Can you reduce the CI builds to 1 at a time? 4 appears to be too much. We already had to do that with ROS2 branch recently (https://github.com/ros-perception/image_pipeline/blob/ros2/.circleci/config.yml), not sure what changed. Maybe Circle is throttling us. |
|
These are the only functional changes I see, maybe changing this cast did something? Alot of the errors I see are
on lines in the test like |
Done @SteveMacenski Sorry for lack of clarification. Here are the build failures that I'm talking about: |
JWhitleyWork
requested review from
SteveMacenski
and removed request for
clalancette
|
My first gut check would be trying to remove the |
|
@SteveMacenski Found it. There was a float division ( |
|
N still failed, weirdly |
If you look at the log, it actually passed but the Github hook seems to report "Unstable" as "failed." Not sure why. |
|
I think it failed from the quality gate due to build warnings. We could also try to rerun. |
|
@SteveMacenski Go for it. I'm not familiar with how to kick builds on the build farm other than pushing changes. |
|
like that ;-) |
SteveMacenski
approved these changes
May 14, 2020
|
Its still closer than the other PR, we should close that since this supersedes |
Closed
|
Still getting failure due to GTK deprecation warnings. I'll look into them real quick. |
|
@SteveMacenski So, oddly, there are 3 deprecated functions in GTK2 that cause these errors while it builds just fine with GTK3. I updated to GTK3. Unfortunately, I have no way to test it since a camera driver hasn't been released yet for Noetic! Really don't think it should be a problem, though. The GTK functionality is very minimal. |
|
I deeply hate GTK and VTK. Its the bane of my maintaining existence. just use rviz |
|
Let me know if you want to release or if I should tomorrow. I don't mind. |
|
I'd appreciate it if you would. I have a lot of Autoware stuff to do tonight. |
|
Will do |
This was referenced May 15, 2020
Closed
wep21
pushed a commit
to wep21/image_pipeline
that referenced
this pull request
Oct 17, 2021
* cmake_minimum_required to 3.0.2 Signed-off-by: ahcorde <ahcorde@gmail.com> * Adapted to OpenCV4 Signed-off-by: ahcorde <ahcorde@gmail.com> * import setup from setuptools instead of distutils-core Signed-off-by: ahcorde <ahcorde@gmail.com> * Adapted .circleci to noetic Signed-off-by: ahcorde <ahcorde@gmail.com> * Updating CI for Noetic with temp image. * Updated directed.py test Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed compilation test_rectify Signed-off-by: ahcorde <ahcorde@gmail.com> * Applying some fixes from ahcorde d1bed52. * Removing import of print_function from __future__. * CI: Reducing simultaneous jobs to 1. * Fixing float/integer division bug. * Updating image_view to use GTK3. Co-authored-by: ahcorde <ahcorde@gmail.com>
JWhitleyWork
pushed a commit
that referenced
this pull request
Nov 11, 2021
* cmake_minimum_required to 3.0.2 Signed-off-by: ahcorde <ahcorde@gmail.com> * Adapted to OpenCV4 Signed-off-by: ahcorde <ahcorde@gmail.com> * import setup from setuptools instead of distutils-core Signed-off-by: ahcorde <ahcorde@gmail.com> * Adapted .circleci to noetic Signed-off-by: ahcorde <ahcorde@gmail.com> * Updating CI for Noetic with temp image. * Updated directed.py test Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed compilation test_rectify Signed-off-by: ahcorde <ahcorde@gmail.com> * Applying some fixes from ahcorde d1bed52. * Removing import of print_function from __future__. * CI: Reducing simultaneous jobs to 1. * Fixing float/integer division bug. * Updating image_view to use GTK3. Co-authored-by: ahcorde <ahcorde@gmail.com>
JWhitleyWork
pushed a commit
that referenced
this pull request
Apr 14, 2022
* cmake_minimum_required to 3.0.2 Signed-off-by: ahcorde <ahcorde@gmail.com> * Adapted to OpenCV4 Signed-off-by: ahcorde <ahcorde@gmail.com> * import setup from setuptools instead of distutils-core Signed-off-by: ahcorde <ahcorde@gmail.com> * Adapted .circleci to noetic Signed-off-by: ahcorde <ahcorde@gmail.com> * Updating CI for Noetic with temp image. * Updated directed.py test Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed compilation test_rectify Signed-off-by: ahcorde <ahcorde@gmail.com> * Applying some fixes from ahcorde d1bed52. * Removing import of print_function from __future__. * CI: Reducing simultaneous jobs to 1. * Fixing float/integer division bug. * Updating image_view to use GTK3. Co-authored-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-write of #507 with some cherry-picks from that branch but without significant feature changes.