Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth image transport configure susbcribers #844

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 10, 2024

Subscribers are setted to SystemDefault QoS sometimes this is not the right QoS of the publisher.

Adding the option to modify the QoS parameters.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Jan 10, 2024
Copy link

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a small test here ? Otherwise LGTM

@ahcorde ahcorde merged commit 8283571 into humble Jan 17, 2024
3 checks passed
ahcorde added a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@mikeferguson mikeferguson deleted the ahcorde/humble/depth_image_proc/config_subscribers branch January 19, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants