Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply #509 and #526 to Noetic Branch #528

Merged
merged 2 commits into from
May 13, 2020
Merged

Apply #509 and #526 to Noetic Branch #528

merged 2 commits into from
May 13, 2020

Conversation

JWhitleyWork
Copy link
Collaborator

No description provided.

@JWhitleyWork
Copy link
Collaborator Author

CI is going to fail until something like #507 is merged. I'm working on an alternative to #507 right now that doesn't start from the ROS2 version.

@SteveMacenski
Copy link
Member

OK got it. I just noticed in the Noetic release blocking page that image pipeline is the last repo that we have directly blocking http://repositories.ros.org/status_page/blocked_releases_noetic.html?s=6&r=1

@JWhitleyWork
Copy link
Collaborator Author

@SteveMacenski If you merge this one, I've created #529 which should allow us to release.

@JWhitleyWork JWhitleyWork merged commit 2aecb57 into noetic May 13, 2020
@SteveMacenski SteveMacenski deleted the noetic-apply-509-526 branch May 13, 2020 21:09
wep21 pushed a commit to wep21/image_pipeline that referenced this pull request Oct 17, 2021
@G-Pereira @k-okada
Apply ros-perception#509 and ros-perception#526 to Noetic Branch (ros…
4703d49 
…-perception#528)

* Fix import path on camera_calibrator.py (ros-perception#509)

* clone cv_ptr->image before set queued_image (ros-perception#526)

Co-authored-by: Gonçalo Camelo Neves Pereira <goncalo_pereira@outlook.pt>
Co-authored-by: Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp>
JWhitleyWork pushed a commit that referenced this pull request Nov 11, 2021
@G-Pereira @k-okada
Apply #509 and #526 to Noetic Branch (#528)
af1da7a 
* Fix import path on camera_calibrator.py (#509)

* clone cv_ptr->image before set queued_image (#526)

Co-authored-by: Gonçalo Camelo Neves Pereira <goncalo_pereira@outlook.pt>
Co-authored-by: Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp>
JWhitleyWork pushed a commit that referenced this pull request Apr 14, 2022
@G-Pereira @k-okada @JWhitleyWork
Apply #509 and #526 to Noetic Branch (#528)
b54c737 
* Fix import path on camera_calibrator.py (#509)

* clone cv_ptr->image before set queued_image (#526)

Co-authored-by: Gonçalo Camelo Neves Pereira <goncalo_pereira@outlook.pt>
Co-authored-by: Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JWhitleyWork @SteveMacenski @G-Pereira @k-okada