fixes for fisheye calibration #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set_cammodel of StereoCalibrator need to override the method of parent class fix related to opencv/opencv#11085 unlike cv2.calibrate, the cv2.fisheye.calibrate method expects float64 points and in an array with an extra dimension. The same for cv2.stereoCalibrate vs cv2.fisheye.stereoCalibrate
SteveMacenski
approved these changes
Jun 10, 2020
|
@soeroesg please submit this patch to |
JWhitleyWork
requested changes
Jun 10, 2020
|
Just one minor thing. |
trimmed whitespace at line endings
JWhitleyWork
approved these changes
Jun 12, 2020
|
Thanks @soeroesg and @JWhitleyWork! |
DavidTorresOcana
pushed a commit
to DavidTorresOcana/image_pipeline
that referenced
this pull request
Aug 23, 2020
* fix ros-perception#503: set_cammodel of StereoCalibrator need to override the method of parent class fix related to opencv/opencv#11085 unlike cv2.calibrate, the cv2.fisheye.calibrate method expects float64 points and in an array with an extra dimension. The same for cv2.stereoCalibrate vs cv2.fisheye.stereoCalibrate * removed commented line; trimmed whitespace at line endings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #503:
set_cammodel of StereoCalibrator need to override the method of parent class
fix related to opencv/opencv#11085
unlike cv2.calibrate, the cv2.fisheye.calibrate method expects float64 points and in an array with an extra dimension. The same for cv2.stereoCalibrate vs cv2.fisheye.stereoCalibrate