Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the laser_proc library shared. #7

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Make the laser_proc library shared. #7

merged 1 commit into from
Jan 13, 2020

Conversation

clalancette
Copy link

This will help it link on Linux when building as a component.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@Karsten1987 FYI, this is part of what I had to do to get the whole URG node building.

This will help it link on Linux when building as a component.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Author

Thanks for the review. @chadrockey As with #6, I'm going to go ahead and merge this, but feel free to comment and we can follow-up.

@clalancette clalancette merged commit 8a41d37 into ros-perception:ros2-devel Jan 13, 2020
@clalancette clalancette deleted the shared-lib branch January 13, 2020 18:14
@Karsten1987
Copy link

I think there went something wrong with this change on Windows:

11:57:58 [15.812s] C:\J\workspace\ci_windows\ws\src\ros-perception\laser_proc\src\laser_publisher.cpp(115,54): warning C4267: '+=': conversion from 'size_t' to 'uint32_t', possible loss of data [C:\J\workspace\ci_windows\ws\build\laser_proc\laser_proc.vcxproj]
11:57:58 [17.000s] C:\J\workspace\ci_windows\ws\src\ros-perception\laser_proc\src\laser_publisher.cpp(117,43): warning C4267: '+=': conversion from 'size_t' to 'uint32_t', possible loss of data [C:\J\workspace\ci_windows\ws\build\laser_proc\laser_proc.vcxproj]
11:57:58 [17.250s]   laser_proc.vcxproj -> C:\J\workspace\ci_windows\ws\build\laser_proc\Release\laser_proc.dll
11:57:58 [17.343s]   Building Custom Rule C:/J/workspace/ci_windows/ws/src/ros-perception/laser_proc/CMakeLists.txt
11:57:58 [17.468s]   laser_proc_component.cpp
11:57:58 [19.718s] LINK : fatal error LNK1181: cannot open input file 'Release\laser_proc.lib' 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants