Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export symbols in laser_proc component #8

Conversation

Karsten1987
Copy link

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Karsten Knese karsten@openrobotics.org

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems totally reasonable to me, with green Windows CI.

@Karsten1987
Copy link
Author

The windows build is expected to be unstable as it built up to urg_node which is not supported on windows. This repo however compiled just fine. Merging.

@Karsten1987 Karsten1987 merged commit 2aac12d into ros-perception:ros2-devel Jan 13, 2020
@Karsten1987 Karsten1987 deleted the ros2-devel-fix-windows branch January 13, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants