update license to BSD-3 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find . -iname *.h* -print -exec bash -c 'file={}; dir=; mkdir -p include/gmapping//; git mv include/gmapping//' \;
for fullfile in $(cd include/; find gmapping/ -type f -print); do headerfile=$(basename $fullfile); echo $fullfile; for targetfile in $(find . -type f -not -path "*/.git/*" -print); do sed -i "s@\([\"<]\)$headerfile\([>\"]\)@\1$fullfile\2@g" $targetfile | grep $headerfile; done; done for fullfile in $(cd include/; find gmapping/ -type f -print); do headerfile=$(basename $fullfile); for targetfile in $(find . -type f -not -path "*/.git/*" -print); do sed -i "s@\([\"<]\)[a-z0-9_/]*/$headerfile\([>\"]\)@\1$fullfile\2@g" $targetfile | grep $headerfile; done; done
/home/user/gmapping_ws/src/openslam_gmapping/gridfastslam/gfs2rec.cpp: In member function ‘virtual void ResampleRecord::read(std::istream&)’:
/home/user/gmapping_ws/src/openslam_gmapping/gridfastslam/gfs2rec.cpp:148:17: error: redeclaration of ‘unsigned int i’
unsigned int i;
^
/home/user/gmapping_ws/src/openslam_gmapping/gridfastslam/gfs2rec.cpp:147:21: error: ‘unsigned int i’ previously declared here
for (unsigned int i=0; i< dim; i++){
^
make[2]: *** [CMakeFiles/gfs2rec.dir/gridfastslam/gfs2rec.cpp.o] Error 1
make[1]: *** [CMakeFiles/gfs2rec.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
This was referenced Jul 10, 2019
Closed
Alessandro-Barbieri
added a commit
to Alessandro-Barbieri/gentoo
that referenced
this pull request
Mar 20, 2021
since 0.2.0 it's BSD licensed see ros-perception/openslam_gmapping#29 Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 30, 2021
since 0.2.0 it's BSD licensed see ros-perception/openslam_gmapping#29 Closes: #20022 Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #20, the licence of original gmapping source has been changed to BSD, and all contributors on this repository agreed changing their code into BSD except @vrabaud , so I first fork original gmapping source tree as melodic-branch (79ef0b0) and changed from rosmake to catkin (this is main contribution of @vrabaud )and add missing patches
c.f. #20 (comment)