-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a Groovy implementation so clients can support both Groovy and Hydro #3
Comments
@jack-oquin I have a version for groovy in the |
I have no more time this afternoon and evening, but I'll test it tomorrow, first thing in the morning. |
I've made the changes to gazebo_ros_pkgs to support the new Groovy branch. I'll merge it in once pcl_conversions is released to Groovy public repos. |
I checked out the groovy-devel branch along with the master branch of the velodyne repository into a Groovy workspace. That is the version of the Velodyne driver you modified to work with PCL 1.7. Everything built cleanly and the Velodyne unit tests run successfully. This will be very helpful. Thanks for doing it. |
No problem, let me know if you run into any other sticking points. |
Some client packages would like to support both Groovy with PCL 1.6 and Hydro with PCL 1.7 in the same source branch.
That is currently not possible because
pcl_conversions
did not exist in Groovy.If possible, the Groovy implementation should emulate the new Hydro interface, making it clean and easy for client programs to support both.
See: ros-perception/perception_pcl#26.
The text was updated successfully, but these errors were encountered: