Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Groovy implementation so clients can support both Groovy and Hydro #3

Closed
jack-oquin opened this issue Jul 18, 2013 · 6 comments

Comments

@jack-oquin
Copy link
Member

Some client packages would like to support both Groovy with PCL 1.6 and Hydro with PCL 1.7 in the same source branch.

That is currently not possible because pcl_conversions did not exist in Groovy.

If possible, the Groovy implementation should emulate the new Hydro interface, making it clean and easy for client programs to support both.

See: ros-perception/perception_pcl#26.

@wjwwood
Copy link
Member

wjwwood commented Jul 18, 2013

@jack-oquin I have a version for groovy in the groovy-devel branch now. I have also started releasing it, can you give it a try with your packages in groovy?

@jack-oquin
Copy link
Member Author

I have no more time this afternoon and evening, but I'll test it tomorrow, first thing in the morning.

@wjwwood
Copy link
Member

wjwwood commented Jul 18, 2013

@davetcoleman

@davetcoleman
Copy link

I've made the changes to gazebo_ros_pkgs to support the new Groovy branch. I'll merge it in once pcl_conversions is released to Groovy public repos.

@jack-oquin
Copy link
Member Author

I checked out the groovy-devel branch along with the master branch of the velodyne repository into a Groovy workspace.

That is the version of the Velodyne driver you modified to work with PCL 1.7. Everything built cleanly and the Velodyne unit tests run successfully.

This will be very helpful. Thanks for doing it.

@wjwwood
Copy link
Member

wjwwood commented Jul 19, 2013

No problem, let me know if you run into any other sticking points.

@wjwwood wjwwood closed this as completed Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants