Fixed draco subscriber parameter names #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
Do you mind to try the combinantion of these two PRs |
|
Thanks for helping out so fast, @ahcorde! I've tested the PR cherrypicked on my ROS2 Humble installation, but I think this shouldn't make a difference. The crash still occurs when parameters of the same subscriber are redeclared (e.g., add different two displays for |
|
I made a new change, do you mind to try it @FranzAlbers ? |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
Thanks @ahcorde, this fixes the crashes! 👍 |
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 48cd0ce)
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 48cd0ce)
ahcorde
added a commit
that referenced
this pull request
Dec 12, 2023
ahcorde
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseed this PR ros-perception/point_cloud_transport_plugins#37
The subscriber param names: