Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document node subscription behaviour #44

Closed
mortenfyhn opened this issue Sep 11, 2020 · 4 comments
Closed

Document node subscription behaviour #44

mortenfyhn opened this issue Sep 11, 2020 · 4 comments

Comments

@mortenfyhn
Copy link

Hi all!

I tried running the pointcloud to laserscan node, by launching the node and remapping cloud_in to my pointcloud topic. I then checked the rqt node graph to see if everything looks nice and connected. But it doesn't! I did some digging and realized that the you must subscribe to the laserscan output before the node will subscribe to the pointcloud input. This was confusing for me. Can we document this behaviour somewhere? I suppose the wiki page is a good location. I tried editing it myself, but I'm having issues with my ros.org login. Another, maybe better way is to have the node print something like "waiting for someone to subscribe to " when starting if nobody subscribes right away, then it will be very clear to the user what he needs to do.

@mortenfyhn
Copy link
Author

I noticed by chance now that this is indeed documented in a repository readme added for the v2 branch. Maybe we could add a similar readme to the current default branch.

@paulbovbel
Copy link
Member

I've updated the default branch to point at ROS2 (onwards!), but PRs are welcome to update the ROS1 readmes

@mortenfyhn
Copy link
Author

Cool! I think that in itself pretty much solves this, because now ROS1 users will likely notice the readme.

@hidmic
Copy link
Collaborator

hidmic commented Dec 9, 2020

@mortenfyhn I'll assume you won't be submitting PRs to update ROS1 READMEs. I'll go ahead and close this issue then. Feel free to re-open if need be.

@hidmic hidmic closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants