Rectify image if any distortion coefficients are non-zero #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
changed the title
| error = cv::sum(diff_image)[0]; | ||
| EXPECT_EQ(error, 0); | ||
|
|
||
| // debug |
There was a problem hiding this comment.
This adds an extra dependency on highgui so I guess you can remove it right ?
There was a problem hiding this comment.
I can remove it and the #include <opencv2/highgui/highgui.hpp> above.
|
looks good overall, please take the comments into account, that just makes less code to review :) And please squash your commits too once done. Thx. |
lucasw
added a commit
to lucasw/vision_opencv
that referenced
this pull request
Mar 3, 2016
…xed comment wording slightly for pull request ros-perception#118
lucasw
force-pushed
the
indigo
branch
2 times, most recently
from
2c284a4
to
ce51a40
Compare
lucasw
added a commit
to lucasw/vision_opencv
that referenced
this pull request
Mar 3, 2016
…stortion coefficients to see if rectification ought to be done
|
Made those changes, and squashed. |
| } | ||
|
|
||
| cv::Mat rectified_image; | ||
| cv::Mat diff_image; |
There was a problem hiding this comment.
this is useless now right ?
…stortion coefficients to see if rectification ought to be done
|
Deleted unused diff image mat. |
|
Thx ! |
vrabaud
added a commit
that referenced
this pull request
Mar 4, 2016
Rectify image if any distortion coefficients are non-zero
|
Thix closes #117 |
luca-della-vedova
pushed a commit
to luca-della-vedova/vision_opencv
that referenced
this pull request
Sep 2, 2020
…ach-end-of-non-void Return default value to prevent missing return warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests included.
For #117