Merge shape_tools package into geometric shapes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am all for merging shape_tools with geometric_shapes, but I think shape_msgs should exist on its own. That way, any tool that wants to listen to shape_msgs is not required to depend on geometric_shapes |
|
@isucan The commit actually has a wrong description -- this isn't merging shape_msgs, but rather shape_tools (which is a set of C++ code). shape_msgs will continue to be exactly what it is. @davetcoleman Could you update the message on your commit to say "shape_tools" rather than "shape_msgs" |
davetcoleman
changed the title
|
Ah yes, my bad on the title |
|
@davetcoleman I was actually talking about the commit log -- I hadn't actually noticed the title of the ticket! |
davetcoleman
force-pushed
the
merge_shape_msgs
branch
from
89be228
to
d5ed2af
Compare
davetcoleman
force-pushed
the
merge_shape_msgs
branch
from
d5ed2af
to
115d86e
Compare
|
Yea, I kept getting those mixed up. Commit renamed. |
mikeferguson
added a commit
that referenced
this pull request
Apr 22, 2015
Merge shape_tools package into geometric shapes
IanTheEngineer
added a commit
to IanTheEngineer/moveit_pr2
that referenced
this pull request
Feb 3, 2016
shape_tools functionality was merged into geometric_shapes: moveit/geometric_shapes#32 Updating the pick and place tutorial and adding geometric_shapes to the package.xml and CMakeLists.txt.
IanTheEngineer
added a commit
to IanTheEngineer/romeo_moveit_actions
that referenced
this pull request
Feb 3, 2016
shape_tools functionality was merged into geometric_shapes: moveit/geometric_shapes#32 and removed from moveit_core moveit/moveit_core#242 which caused this issue. This commit updates the pick and place tutorial and adds geometric_shapes to the package.xml and CMakeLists.txt to prevent the ROS buildfarm from failing to build this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in ros-planning/shape_tools#4
This adds the two files in shape_tools to this package. I think we should release this package, then, once it is public, start switching the rest of MoveIt! to use this version of the shape message functions. Note I have already build all of MoveIt locally with this new setup.