Clarify "id" parameter in RobotState & collision world #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixvd
requested review from
BryceStevenWilley,
mlautman and
rhaschke
as code owners
felixvd
force-pushed
the
clarify-id-parameters
branch
from
362f5ee
to
6fa52e1
Compare
felixvd
force-pushed
the
clarify-id-parameters
branch
from
6fa52e1
to
632d3bb
Compare
|
Will be thankful for getting this merged soon, so the other PR becomes more readable. |
BryceStevenWilley
approved these changes
Apr 26, 2019
|
My fault @rhaschke, I accidentally merged instead of squash-merging. Is there a good way to fix that on master? |
rhaschke
pushed a commit
that referenced
this pull request
Apr 26, 2019
|
Done. There wasn't another commit yet. |
11 tasks
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 30, 2020
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes some parameters in the robot state and collision world clearer, as requested by @mlautman in #1060, in a separate PR as requested by @rhaschke in #1439. This PR changes nothing except the internal names.
Can be cherry-picked to kinetic and melodic.
Checklist