-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get joint model names from joint_model_group_ #1569
Conversation
Thanks for helping in improving MoveIt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Obviously, you didn't test this change.
The joint_model_group_
variable was never initialized and thus cannot be used. I think you should use the RobotModelLoader
to create a RobotModel
and from there you can access JointModelGroups.
d45e1c0
to
4f012c1
Compare
Remove dependence on move_group action server by getting the joint model names through joint_model_group_ instead.
4f012c1
to
dd0df39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me,
although I don't see a reason to have a clang-tidy fixup included in the same commit...
Best to split into two commits? Or just let clang-tidy fail? |
I approved, nothing needs to be changed.
The comment was just my personal opinion.
Best to split into two commits? Or just let clang-tidy fail?
CI failures have to be fixed.
I would always keep such "fixups" in one separate commit though.
I'm sure opinions among maintainers differ on whether things like that should be separated or squashed.
|
Congrats on getting your first MoveIt! pull request merged and improving open source robotics! |
Remove dependence on move_group action server by getting the joint model names through joint_model_group_ instead.
Description
closes #1563
Uses joint_model_group_ instead of MoveGroupInterface to get joint names
Checklist