Get joint model names from joint_model_group_ #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping in improving MoveIt! |
rhaschke
previously requested changes
Jul 17, 2019
There was a problem hiding this comment.
Thanks for this contribution. Obviously, you didn't test this change.
The joint_model_group_ variable was never initialized and thus cannot be used. I think you should use the RobotModelLoader to create a RobotModel and from there you can access JointModelGroups.
Dale-Koenig
force-pushed
the
joint_model_names
branch
2 times, most recently
from
d45e1c0
to
4f012c1
Compare
Remove dependence on move_group action server by getting the joint model names through joint_model_group_ instead.
Dale-Koenig
force-pushed
the
joint_model_names
branch
from
4f012c1
to
dd0df39
Compare
v4hn
approved these changes
Jul 30, 2019
Best to split into two commits? Or just let clang-tidy fail? |
|
I approved, nothing needs to be changed.
The comment was just my personal opinion.
Best to split into two commits? Or just let clang-tidy fail?
CI failures have to be fixed.
I would always keep such "fixups" in one separate commit though.
I'm sure opinions among maintainers differ on whether things like that should be separated or squashed.
|
rhaschke
approved these changes
Jul 31, 2019
|
Congrats on getting your first MoveIt! pull request merged and improving open source robotics! |
2 tasks
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependence on move_group action server by getting the joint model names through joint_model_group_ instead.
Description
closes #1563
Uses joint_model_group_ instead of MoveGroupInterface to get joint names
Checklist