Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-tidy for unified collision environment #1638

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

j-petit
Copy link
Contributor

@j-petit j-petit commented Aug 21, 2019

Description

Travis fails due to performance-unnecessary-value-param which has been introduced through the new unified environment in #1584. This fixes the issue.

Checklist

@j-petit j-petit requested a review from rhaschke as a code owner August 21, 2019 20:28
@BryceStevenWilley
Copy link
Contributor

Merging as this fixes a failing build.

@BryceStevenWilley BryceStevenWilley merged commit 06d67ab into moveit:master Aug 21, 2019
Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speed!

@j-petit j-petit deleted the fix-unified-env branch August 22, 2019 08:08
rhaschke added a commit to ubi-agni/moveit that referenced this pull request Sep 11, 2019
henningkayser pushed a commit to PickNikRobotics/moveit that referenced this pull request Nov 21, 2019
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants