Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing jog_arm segfault #1692

Merged
merged 2 commits into from
Nov 1, 2019

Conversation

mlautman
Copy link
Contributor

Description

Fixes a segfault issue with jog_arm where the fix bounds method tries to access invalid indices inthe velocity vector. Not sure if this is the best way to fix this. @AndyZe

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I approve. A small nitpick is pending.

moveit_experimental/moveit_jog_arm/src/jog_calcs.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
@henningkayser henningkayser merged commit 2bef2b6 into moveit:master Nov 1, 2019
@tylerjw tylerjw mentioned this pull request May 8, 2020
20 tasks
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 20, 2020
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants