-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing jog_arm segfault #1692
Merged
henningkayser
merged 2 commits into
moveit:master
from
PickNikRobotics:jog-arm-vel-segfault
Nov 1, 2019
Merged
fixing jog_arm segfault #1692
henningkayser
merged 2 commits into
moveit:master
from
PickNikRobotics:jog-arm-vel-segfault
Nov 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
reviewed
Oct 15, 2019
mlautman
force-pushed
the
jog-arm-vel-segfault
branch
from
October 17, 2019 17:24
391a298
to
f0c0933
Compare
AndyZe
approved these changes
Oct 17, 2019
AndyZe
requested changes
Oct 17, 2019
mlautman
force-pushed
the
jog-arm-vel-segfault
branch
from
October 18, 2019 20:48
f0c0933
to
dcd8ce6
Compare
AndyZe
approved these changes
Oct 18, 2019
rhaschke
approved these changes
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I approve. A small nitpick is pending.
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
henningkayser
approved these changes
Nov 1, 2019
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 20, 2020
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a segfault issue with jog_arm where the fix bounds method tries to access invalid indices inthe velocity vector. Not sure if this is the best way to fix this. @AndyZe