support unique_ptr. #1771
Merged
support unique_ptr. #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
approved these changes
Nov 24, 2019
|
I started to implement UniquePtrs as well. Merged. Next I will address the (unrelated) Travis issue. |
rhaschke
pushed a commit
that referenced
this pull request
Nov 24, 2019
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Nov 24, 2019
If I see this correctly, you introduced it with a direct push to the |
rhaschke
pushed a commit
that referenced
this pull request
Nov 24, 2019
|
Yes, I cleaned up the recent history (since yesterday) of both master and melodic-devel branches |
|
Yes, I cleaned up the recent history (since yesterday) of both master and melodic-devel branches
to have the very same commits on both branches for the following PRs:
I do understand your motivation, but force-pushing the main branches is bad nonetheless.
|
sjahr
added a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
…oveit#1771) * Add a version of computeTimeStamps() to yield a fixed num. waypoints * Add unit test * Prevent an ambiguous function signature * Remove debugging stuff * Can't have fewer than 2 waypoints * Warning about sparse waypoint spacing * Doxygen comments * Clarify about changing the shape of the path * Better comment Co-authored-by: Sebastian Jahr <sebastian.jahr@tuta.io> Co-authored-by: Sebastian Jahr <sebastian.jahr@tuta.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately, we encountered a number of interfaces, where unique_ptr
would be the preferred smart pointer to use.
This adds them to the class forward macros.
Fixes #1770 .