Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov #1776

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Codecov #1776

merged 2 commits into from
Nov 28, 2019

Conversation

rhaschke
Copy link
Contributor

Reopening #1765. This is an alternative to #1719, not requiring to touch cmake files.

@rhaschke rhaschke requested a review from v4hn as a code owner November 25, 2019 14:29
@tylerjw
Copy link
Member

tylerjw commented Nov 25, 2019

This produced a different but not yet working report: https://codecov.io/gh/ros-planning/moveit/tree/d993faaccd979e3aa33799637d0a8ecf067cfe17

@tylerjw
Copy link
Member

tylerjw commented Nov 25, 2019

Also, ccache performance on this was bad (note that the cache size is 500mb), this may have something to do with travis not having a cache to provide for this build as it wasn't able to retrieve the one produced from the previous PR you submitted:

cache directory                     /root/.ccache
primary config                      /root/.ccache/ccache.conf
secondary config      (readonly)    /etc/ccache.conf
stats zero time                     Mon Nov 25 14:38:25 2019
cache hit (direct)                     0
cache hit (preprocessed)               0
cache miss                           790
cache hit rate                      0.00 %
called for link                      662
called for preprocessing              14
no input file                         52
cleanups performed                     2
files in cache                      2273
cache size                         352.1 MB
max cache size                     500.0 MB

@rhaschke
Copy link
Contributor Author

It's annoying that the recommended way to upload coverage reports doesn't work as expected.
Running genhtml locally, generates a correct report from the coverage trace created by my approach.
I will file a bug report to codecov.io.

@tylerjw
Copy link
Member

tylerjw commented Nov 26, 2019

I tested this locally and confirmed this is some issue with codecov.io. Hopefully they can fix that soon. I also tested ccache and I can't reproduce the low cache hits locally :/ I think it has something to do with travis and I don't know yet how to debug that.

@rhaschke
Copy link
Contributor Author

I filed an issue with codecov.io: codecov/codecov-bash#232

@rhaschke rhaschke merged commit d48d57f into moveit:master Nov 28, 2019
@rhaschke rhaschke deleted the codecov branch November 28, 2019 07:16
This was referenced Nov 28, 2019
@rhaschke
Copy link
Contributor Author

Hi @tylerjw,
I just merged this, but the coverage report is not accessible on codecov.io. Do we need further settings here or at codecov.io to enable this?

image

@tylerjw
Copy link
Member

tylerjw commented Nov 28, 2019

@rhaschke When you go to the overview page it shows that kinetic-devel is the main branch and there isn't a coverage report for that. I believe that is the issue and you should be able to configure it to look at the master branch in the settings page. I'm not a maintainer so I can't see that page (I get a "401 forbidden" if I try to go there). The other thing you'll find there is the markdown code to add the badge to the readme.

sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
* Set the resample_dt_ member of TOTG back to const

* Remove unused TOTG instance in test

Co-authored-by: Henning Kayser <henningkayser@picknik.ai>

* Add "totg" to function name

Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants