Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioning for jog_arm package #1948

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Conversation

JafarAbdi
Copy link
Member

@JafarAbdi JafarAbdi commented Mar 10, 2020

Description

I'm working on a build farm that uses the master branch for Debian releases, but running git-bloom-generate -y rosrelease melodic gives

RuntimeError: Two packages have different version numbers (0.0.3 != 1.0.1):
- /tmp/tmpuEevgo/clone/moveit_experimental/moveit_jog_arm/package.xml

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will enable the standard bloom release process.

@codecov-io
Copy link

Codecov Report

Merging #1948 into master will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
- Coverage   50.29%   49.82%   -0.48%     
==========================================
  Files         313      313              
  Lines       24652    24714      +62     
==========================================
- Hits        12398    12313      -85     
- Misses      12254    12401     +147
Impacted Files Coverage Δ
..._adapter_plugins/src/resolve_constraint_frames.cpp 13.33% <0%> (-86.67%) ⬇️
...veit_core/robot_model/src/floating_joint_model.cpp 26.37% <0%> (-13.74%) ⬇️
...anning_scene_monitor/src/current_state_monitor.cpp 40% <0%> (-12.83%) ⬇️
moveit_core/robot_model/src/joint_model.cpp 60.95% <0%> (-10.48%) ⬇️
moveit_ros/move_group/src/move_group.cpp 83.87% <0%> (-6.46%) ⬇️
moveit_core/kinematic_constraints/src/utils.cpp 19.64% <0%> (-3.22%) ⬇️
...bot_state/include/moveit/robot_state/robot_state.h 89.1% <0%> (-1.93%) ⬇️
...veit_experimental/moveit_jog_arm/src/jog_calcs.cpp 68.96% <0%> (-1.55%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 80% <0%> (-1.46%) ⬇️
...t_setup_assistant/src/tools/moveit_config_data.cpp 20.91% <0%> (-0.97%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0abd095...357be28. Read the comment docs.

@v4hn v4hn merged commit 8b2a081 into moveit:master Mar 13, 2020
@tylerjw tylerjw mentioned this pull request May 8, 2020
20 tasks
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 20, 2020
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants