-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgi: add execution methods for moveit_msgs::RobotTrajectory #1955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of introducing two new function variants, what about introducing a single (implicit) constructor of Plan from RobotTrajectory? This way, it should be possible to pass a RobotTrajectory to the existing functions.
Actually, if you want to unify them, I would propose to simply deprecate the old execute method. |
This eliminates the common question how to execute a planned Cartesian trajectory and provides a useful API either way.
031be8d
to
12a77eb
Compare
After thinking about it a bit more, I decided to leave the old interfaces around without deprecation. |
Codecov Report
@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
+ Coverage 49.83% 49.87% +0.04%
==========================================
Files 314 314
Lines 24720 24726 +6
==========================================
+ Hits 12319 12332 +13
+ Misses 12401 12394 -7
Continue to review full report at Codecov.
|
It makes a lot of sense for the move group to execute a trajectory instead of a plan. I like this. |
* Generate Doxygen Tag * Install tagfile in output directory * Fix problematic override for Doxygen linking
I just reviewed moveit/moveit_tutorials#468 and
thought this would be a nicer way to execute Cartesian trajectories...