Export moveit_py_bindings_tools library #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
There's no harm in exposing what is already there anyway...
Keep in mind though that MoveIt is no python binding framework, so no guarantees on stability in these tools. I believe @rhaschke planned for quite some time now to rework this entirely in pybind11
6 tasks
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Mar 28, 2020
Co-authored-by: Bjar Ne
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to use the py_bindings_tools for my own Python C++ wrappers, but it's not yet included in
catkin_package(). This results in a linking error (undefined symbolmoveit::py_binding_tools::ROScppInitializer::ROScppInitializer()) when trying to load the Python C extension.Btw., should this and #1870 be backported to melodic?
Checklist