-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commander: python3 fix #2030
commander: python3 fix #2030
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
+ Coverage 54.08% 54.09% +0.01%
==========================================
Files 319 319
Lines 24997 24997
==========================================
+ Hits 13519 13523 +4
+ Misses 11478 11474 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on python3 compatibility. 👍 👍 👍
[tangent] Do you know if we could have our python tests run with python3 to find areas in our python code that need updated and keep them compatible?
I don't have much of a choice, running on a python-3 based system 🗡️
Once we have noetic CI set up, it's going to test for python 3 automatically. |
* Fix getting variable bounds in mimic joints for TOTG * Formatting * Remove unnecessary code * Do not include mimic joints in timing calculations * Change joint variable bounds at mimic creation time * Braces take you places * Fix other single-line if-else without braces in file for clang_tidy * Remove mimic bounds modification * Variable renaming and a comment * Fix index naming --------- Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> Co-authored-by: Jafar <cafer.abdi@gmail.com> Co-authored-by: AndyZe <andyz@utexas.edu>
There is certainly more, but this allows to
use <group>\ngo <named_state>