Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commander: python3 fix #2030

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Apr 18, 2020

There is certainly more, but this allows to use <group>\ngo <named_state>

@v4hn v4hn requested a review from rhaschke as a code owner April 18, 2020 19:29
@codecov-io
Copy link

Codecov Report

Merging #2030 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
+ Coverage   54.08%   54.09%   +0.01%     
==========================================
  Files         319      319              
  Lines       24997    24997              
==========================================
+ Hits        13519    13523       +4     
+ Misses      11478    11474       -4     
Impacted Files Coverage Δ
...meterization/work_space/pose_model_state_space.cpp 82.99% <0.00%> (+0.68%) ⬆️
...anning_scene_monitor/src/current_state_monitor.cpp 52.82% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173d6a6...d37d301. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on python3 compatibility. 👍 👍 👍

[tangent] Do you know if we could have our python tests run with python3 to find areas in our python code that need updated and keep them compatible?

@v4hn
Copy link
Contributor Author

v4hn commented Apr 19, 2020

Thank you for working on python3 compatibility. +1 +1 +1

I don't have much of a choice, running on a python-3 based system 🗡️

[tangent] Do you know if we could have our python tests run with python3 to find areas in our python code that need updated and keep them compatible?

Once we have noetic CI set up, it's going to test for python 3 automatically.
That again still depends on a number of packages to be released for noetic (not just MoveIt).

@v4hn v4hn merged commit 9a9f779 into moveit:master Apr 19, 2020
@tylerjw tylerjw mentioned this pull request May 8, 2020
20 tasks
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 11, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 13, 2020
@v4hn v4hn mentioned this pull request May 20, 2020
sjahr added a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
* Fix getting variable bounds in mimic joints for TOTG

* Formatting

* Remove unnecessary code

* Do not include mimic joints in timing calculations

* Change joint variable bounds at mimic creation time

* Braces take you places

* Fix other single-line if-else without braces in file for clang_tidy

* Remove mimic bounds modification

* Variable renaming and a comment

* Fix index naming

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
Co-authored-by: Jafar <cafer.abdi@gmail.com>
Co-authored-by: AndyZe <andyz@utexas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants