Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTG: add zero parameterization for single-waypoint trajectories #2054

Merged
merged 2 commits into from
May 6, 2020

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented May 5, 2020

Also add some overdue helpers to RobotState while I was at it.
I'm happy to discuss naming if someone disagrees with my terminology.

The actual TOTG issue came up in:
#2052 (comment)

v4hn added 2 commits May 5, 2020 23:03
Sure, some of them will probably almost never be used,
but I prefer full flexibility over missing an intuitive interface in the long run.

Before this patch it was impossible to remove dynamics information
from a state once it was added.
.. as they might be generated by a planner when the goal is already reached.
@v4hn v4hn force-pushed the pr-master-totg-one-waypoint branch from c00d264 to 12797f1 Compare May 5, 2020 21:04
@codecov-io
Copy link

Codecov Report

Merging #2054 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2054      +/-   ##
==========================================
- Coverage   54.61%   54.53%   -0.09%     
==========================================
  Files         328      328              
  Lines       25597    25624      +27     
==========================================
- Hits        13980    13974       -6     
- Misses      11617    11650      +33     
Impacted Files Coverage Δ
...bot_state/include/moveit/robot_state/robot_state.h 91.02% <ø> (ø)
moveit_core/robot_state/src/robot_state.cpp 44.40% <0.00%> (-1.22%) ⬇️
...cessing/src/time_optimal_trajectory_generation.cpp 75.83% <0.00%> (-0.37%) ⬇️
...e/src/parameterization/model_based_state_space.cpp 70.34% <0.00%> (-2.76%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 59.39% <0.00%> (-2.43%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 70.95% <0.00%> (+0.44%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 82.99% <0.00%> (+0.68%) ⬆️
...anning_scene_monitor/src/current_state_monitor.cpp 52.82% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37bbccf...12797f1. Read the comment docs.

@v4hn v4hn merged commit 2bebf05 into moveit:master May 6, 2020
@v4hn v4hn mentioned this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants