Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signal for planning_attempts #2082

Merged
merged 1 commit into from
May 12, 2020

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented May 12, 2020

fixup for dfb00da

@v4hn v4hn requested a review from rhaschke as a code owner May 12, 2020 11:49
@rhaschke rhaschke merged commit 50e3c21 into moveit:master May 12, 2020
@simonschmeisser
Copy link
Contributor

Did we drop Qt4 already? Then this could be checked at compile time by using modern style connects

@rhaschke
Copy link
Contributor

Is there a nice tool available to upgrade all connects?

@simonschmeisser
Copy link
Contributor

https://github.com/KDE/clazy can do that

@v4hn
Copy link
Contributor Author

v4hn commented May 12, 2020

Did we drop Qt4 already? Then this could be checked at compile time by using modern style connects

Yes we can upgrade the slot connects, I just wanted to keep the old style consistent and did not want to spend even more time on refactoring for now.

Pull-requests that ran automatic tools and upgrade the format are clearly appreciated 😎

v4hn added a commit to v4hn/moveit that referenced this pull request May 18, 2020
@v4hn v4hn mentioned this pull request May 20, 2020
sjahr added a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
* Throw if IK solver doesn't exist

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants