-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Python integration tests #2186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting python tests because they are the only ones (using the framework) is a bad excuse. We have too few python tests as-is.
But as these are not at all related to our python interfaces, but only test ROS interfaces, they can be dropped indeed.
Codecov Report
@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
+ Coverage 57.61% 57.77% +0.15%
==========================================
Files 327 326 -1
Lines 24923 25661 +738
==========================================
+ Hits 14359 14825 +466
- Misses 10564 10836 +272
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Andy, you are the maintainer of this. So, I trust your decision.
which (mostly) are redundant to the corresponding C++ tests.
Previously there was a mix of C++ tests and Python tests. The Python tests require a ros-pytest dependency (this is the only package in MoveIt that uses it). That's a little bit of a maintenance burden.
This just deletes the Python tests. Some of them are redundant with C++ anyway. The test coverage that we'll be losing is:
But we can add those to the C++ tests relatively easily now that we have a good framework for it.
Discussion about ros-pytest here: #2066 (comment)